[bug] Resolved. 752+ Claims got overwritten.

Home Forums PirateCraft Server Updates [bug] Resolved. 752+ Claims got overwritten.

Viewing 12 posts - 1 through 12 (of 12 total)
  • Author
    Posts
  • #54283
    GodsDead
    Keymaster
    • Topics: 794
    • Replies: 3344
    • Total: 4138
    • ★★★★★★★★

    This is probably one of the biggest disasters I cant fix in a very, very long time.

    You may have noticed a few very long term players have lost claims and posted in the forums, CrazyPirate, Markusi13, JavaInvader and admin claims. Today we managed to hit the nail on the head, and its not a good nail.

    The design of the claim plugin has a table with a “next claim ID” in it, this is a terrible design, there is no need for it with auto incrementing ID’s, what this does is give the next claim created/changed its unique ID. For an unknown reason in the plugins logic, it was reset at an unknown time, what that means is that every new claim created from that point, was giving an ID from the beginning, so that new claim overwrote the old claim, so the old claim would disappear! we JUST figured this out after months of trying to figure out what was happening. There was no logs of this, at all as everything was working as intended, just with the wrong ID’s.

    I wrote a ticket to the developer on September 5th trying to figure out the missing claims, in this I documented that we had claims up to ID
    72287, and the nextclaimID was set at 3517. Today over a month later, the claims were still at 72287, this should increment, but it hasn’t! but the nextclaimID was at 4266, this means in the last month alone 749 claims have been overwritten! Oh shit! Now since we have so many claims, it will only effect the first 4000 claims ever created back about 3-4 years ago, unlucky for those long term players only. So check your claims.

    • This will only effect very long term players that created the first 4266 claims.
    • When claims are deleted, they ID gets lost, so its probably much much less than 4k claims, back then  claims were made and deleted a lot more as there wasn’t an expand function, so lets call it 2k claims lost.
    • There isn’t a way for me to know for sure what was effected, and I cant change it, if I put back the old data, then the new claims that overwrote them would be deleted!
    • This means there are a hell of a lot of old claims that were purged from the world, I’m going to class this as a mistaken cleanup, feel free to loot/fixup/re-claim anything you like the look of.
    • No “claim blocks” would have been lost from anyone at all, those that had their claims overwritten would have got back the “claim blocks” to reuse. Claim blocks are generated dynamically based on your claims you have in the world.
    • Its now fixed, I will keep an eye to make sure it dousnt drop again.
    • We don’t know when it started.
    • We don’t know what caused the ClaimID to reset.
    • The developer knows about this and is looking into the cause.
    • This shouldn’t affect 95% of the players, But I wanted everyone to know. Only those that have some of the very first claims on PirateCraft V2 from 3-4+ years ago.

    Whats so utterly frustrating is this is a 5 second fix, I just fixed the NextClaimID to be the correct next ID, we tested it and new claims are given the correct ID now.

     

    #54284
    Bazurka
    Moderator
    • Topics: 39
    • Replies: 414
    • Total: 453
    • ★★★★★

    Whoa – nice detective work.
    I am gonna check my oldest claim and hold until it’s conclusion whether I am gonna freak out or not. xD

    Thanks for letting us know.

    Baz

    Proud Member of the Piratecraft history 🙂

    https://minecraftskinstealer.com/achievement/3/Achievement+Get%21/PirateCraft+Regular

    #54285
    MCMonkeyGMx
    Member
    • Topics: 10
    • Replies: 186
    • Total: 196
    • ★★★★

    I dont know whether or not Im included in that category. I’m probably not, but, better safe than sorry!

    This post that I posted on this post about something is probably useles information.............

    #54288
    GodsDead
    Keymaster
    • Topics: 794
    • Replies: 3344
    • Total: 4138
    • ★★★★★★★★

    I dont know whether or not Im included in that category. I’m probably not, but, better safe than sorry!

    Very likely not. it will be a very, very small portion of current players, that may have lost a claim or two.

    Its only if they haven’t deleted and remade the claim in that time too, most of the time they delete their claim and resize it. so that’s why it been do random and hard to pinpoint as there wasn’t a pattern, it was “My claim disappeared next to my vault”, that dousnt give us much to work with!

    I’m just happy I figured it out and it was an easy fix. I’ve only had 3 players complain of missing claims (so far).

    I keep backups from day 1, so What I will do it pull in an old database backup and compare the two tables to see what has actually changed. You never know, we might be surprised, then I should be able to give a rough estimate of who was affected, and even put up a list of Tppos for raiding haha

    #54289
    Bislo
    Member
    • Topics: 67
    • Replies: 640
    • Total: 707
    • ★★★★★★

    oh.. nice, so thats why half my claims were disappearing

    Founder of Port Hope

    #54293
    GodsDead
    Keymaster
    • Topics: 794
    • Replies: 3344
    • Total: 4138
    • ★★★★★★★★

    oh.. nice, so thats why half my claims were disappearing

    Welcome to the Elite group! That makes 5 people in total so far! the 1%! haha

    #54332
    Xeron
    Blocked
    • Topics: 94
    • Replies: 650
    • Total: 744
    • ★★★★★★

    This should only affect players who were playing on here from 2014 – January 2015
    Please please please double check as many claims as you can

    « Build Team leader »
    « Server Admin »
    Crew History: Red Lotus, 0utlaws, Ottoman Empire, Xenon Empire, The Xanthian Order, The Asylum, Xenia
    @Xeron

    #54353
    Crazy Pirate
    Member
    • Topics: 110
    • Replies: 1997
    • Total: 2107
    • ★★★★★★★

    #Oldies

    Timhuisman’s gonna be in for a shocker when he comes back. Can an admin claim his Indian themed town (Karjat) just for heritage purposes? Its a pretty awesome area.

    #54363
    GodsDead
    Keymaster
    • Topics: 794
    • Replies: 3344
    • Total: 4138
    • ★★★★★★★★

    #Oldies Timhuisman’s gonna be in for a shocker when he comes back. Can an admin claim his Indian themed town (Karjat) just for heritage purposes? Its a pretty awesome area.

    Is it unclaimed? PM me the coords so its not in global, some asshole will ruin it.

    #54417
    MinisterMoo
    Member
    • Topics: 5
    • Replies: 95
    • Total: 100
    • ★★★★

    Oi, for most people idk if theyd be thinking “Ooooh, more places to raid…” im not implying myself >~>

    im a kau

    #54434
    wiskey_waters
    Blocked
    • Topics: 16
    • Replies: 161
    • Total: 177
    • ★★★★

    wot about director avian can an admin claim that for him, hes got a few bases, there is one east of wiskey peak well south east, idk its east of it, less than 3k out… i got him to join for like 5 minutes, i asked for his god stuff, he said no saying that he might come back to this server……

    royal navy shipwright
    developer of advanced armour for ships
    turns on hitboxes when pvping

    #54450
    GodsDead
    Keymaster
    • Topics: 794
    • Replies: 3344
    • Total: 4138
    • ★★★★★★★★

    wot about director avian can an admin claim that for him, hes got a few bases, there is one east of wiskey peak well south east, idk its east of it, less than 3k out… i got him to join for like 5 minutes, i asked for his god stuff, he said no saying that he might come back to this server……

    If you send an admin tppos. being vague wont help!

Viewing 12 posts - 1 through 12 (of 12 total)

The topic ‘[bug] Resolved. 752+ Claims got overwritten.’ is closed to new replies.

/50 Online

Mobile Page

Join the PirateCraft discord server
Join the PirateCraft Discord server! discord.piratemc.com
Reddit - PirateCraft Subreddit PirateCraft YouTube PirateCraft Twitter PirateCraft Instagram PirateCraft Facebook